From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Remove configure --disable-float4-byval and --disable-float8-byval |
Date: | 2019-10-31 13:36:30 |
Message-ID: | 15316.1572528990@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> float4 is now always pass-by-value; the pass-by-reference code path is
> completely removed.
I think this is OK.
> float8 and related types are now hardcoded to pass-by-value or
> pass-by-reference depending on whether the build is 64- or 32-bit, as
> was previously also the default.
I'm less happy with doing this. It makes it impossible to test the
pass-by-reference code paths without actually firing up a 32-bit
environment. It'd be fine to document --disable-float8-byval as
a developer-only option (it might be so already), but I don't want
to lose it completely. I fail to see any advantage in getting rid
of it, anyway, since we do still have to maintain both code paths.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2019-10-31 13:54:24 | Re: Allow CREATE OR REPLACE VIEW to rename the columns |
Previous Message | Julien Rouhaud | 2019-10-31 13:21:03 | Re: Collation versioning |