From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
Cc: | Erikjan Rijkers <er(at)xs4all(dot)nl>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Tomas Vondra <tv(at)fuzzy(dot)cz>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Pavel Stìhule <pavel(dot)stehule(at)gmail(dot)com> |
Subject: | Re: WIP: index support for regexp search |
Date: | 2013-04-08 05:28:39 |
Message-ID: | 15279.1365398919@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Alexander Korotkov <aekorotkov(at)gmail(dot)com> writes:
> [ trgm-regexp-0.15.patch.gz ]
I spent the weekend hacking on this, making a number of bug fixes and a
whole lot of cosmetic changes. I think there are large parts of this
that are in committable shape now, but I still find the actual graph
transformation logic to be mostly unintelligible. I think what's most
obscure is the distinction between the arcs list and the keys list of
each state in the expanded graph. I get the impression that the
general idea is for the arcs to represent exactly-known transitions
while the keys represent imprecisely-known transitions ... but there
seems to be at least some leakage between those categories. Could
you write down a specification for what's supposed to be happening
there?
regards, tom lane
Attachment | Content-Type | Size |
---|---|---|
trgm-regexp-0.16.patch.gz | application/octet-stream | 27.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2013-04-08 06:09:49 | Re: [PATCH] Exorcise "zero-dimensional" arrays (Was: Re: Should array_length() Return NULL) |
Previous Message | Brendan Jurd | 2013-04-08 00:49:04 | Re: [PATCH] Exorcise "zero-dimensional" arrays (Was: Re: Should array_length() Return NULL) |