| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Oleg Bartunov <oleg(at)sai(dot)msu(dot)su> |
| Cc: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: patch for contrib/intarray (current CVS) |
| Date: | 2001-08-03 01:47:42 |
| Message-ID: | 15244.996803262@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Oleg Bartunov <oleg(at)sai(dot)msu(dot)su> writes:
> please apply attached patch to current CVS.
> 1. Fixed error with empty array ( '{}' ),
> test data changed to include such data
> 2. Test a dimension of an array ( we support only one-dimension)
Looks okay in a quick glance, except error message spelling is poor:
! #define ARRISNULL(x) ( (x) ? ( ( ARR_NDIM(x) == NDIM ) ? ( ( ARRNELEMS( x ) ) ? 0 : 1 ) : ( ( ARR_NDIM(x) ) ? (elog(ERROR,"Array is not one-dimentional: %d dimentions", ARR_NDIM(x)),1) : 1 ) ) : 1 )
Should be "one-dimensional" and "dimensions". Bruce, would you fix that
when you apply it?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mike Mascari | 2001-08-03 01:56:49 | Re: TRUNCATE question |
| Previous Message | Hiroshi Inoue | 2001-08-03 01:45:42 | Re: AW: OID wraparound: summary and proposal |