Re: Fwd: [TESTERS] [PostgreSQL 9.1 alpha5] OpenBSD and Loongson

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Josh Berkus <josh(at)agliodbs(dot)com>
Cc: postgres hackers <pgsql-hackers(at)postgresql(dot)org>, postgresql(at)raveland(dot)org
Subject: Re: Fwd: [TESTERS] [PostgreSQL 9.1 alpha5] OpenBSD and Loongson
Date: 2011-04-07 16:37:53
Message-ID: 15234.1302194273@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Josh Berkus <josh(at)agliodbs(dot)com> writes:
> I need the following patch to make PostgreSQL happy
> on Loongson with OpenBSD (http://www.openbsd.org/loongson.html)
> These restrictions no longer exist on OpenBSD.
> Tested with the latest alpha (9.1 alpha5) and with
> the latest 9 release (9.0.3).

I'm a bit inclined to think the right fix is not exactly what is
proposed here, but rather to make the openbsd (and freebsd) versions of
this file look like the netbsd one, viz

#if !defined(HAVE_DLOPEN)
snprintf(error_message, sizeof(error_message),
"dlopen (%s) not supported", file);
return NULL;
#else

Since you can't do much useful without dlopen support in any modern
version of Postgres, it doesn't seem like there is much risk of breaking
any working situation --- so we might as well back-patch, too.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Selena Deckelmann 2011-04-07 17:22:26 Headcount for PL Summit, Saturday May 21, 2011 at PgCon
Previous Message Josh Berkus 2011-04-07 16:31:02 Re: pg_upgrade bug found!