| From: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Michail Nikolaev <michail(dot)nikolaev(at)gmail(dot)com> |
| Subject: | Re: [WIP PATCH] Index scan offset optimisation using visibility map |
| Date: | 2018-03-12 12:40:50 |
| Message-ID: | 152085845014.1307.17921890299725656162.pgcf@coridan.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation: tested, passed
I've tested this patch with different types of order by, including needing recheck, but everything seems to work as expected.
There are some missing spaces before some comment lines and I'm a bit unsure on some lines of code duplicated between nodeIndexonlyscan.c and nodeIndexscan.c
But besides this, I have no more notes on the code.
I think the patch is ready for committer.
Best regards, Andrey Borodin.
The new status of this patch is: Ready for Committer
| From | Date | Subject | |
|---|---|---|---|
| Next Message | amul sul | 2018-03-12 13:03:44 | Re: [HACKERS] Restrict concurrent update/delete with UPDATE of partition key |
| Previous Message | Ashutosh Bapat | 2018-03-12 12:37:07 | Re: [HACKERS] Partition-wise aggregation/grouping |