| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "Anton A(dot) Melnikov" <a(dot)melnikov(at)postgrespro(dot)ru> |
| Cc: | John Naylor <johncnaylorls(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, Ants Aasma <ants(dot)aasma(at)cybertec(dot)at>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Junwang Zhao <zhjwpku(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Gurjeet Singh <gurjeet(at)singh(dot)im>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Change GUC hashtable to use simplehash? |
| Date: | 2025-01-16 01:36:01 |
| Message-ID: | 1520769.1736991361@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
"Anton A. Melnikov" <a(dot)melnikov(at)postgrespro(dot)ru> writes:
> Seems it is possible to exclude much less code from checking
> under valgrind and get the same result by replacing the only
> function call pg_rightmost_one_pos64() with a valgrind-safe
> code. See the attached patch, please.
There is no place anywhere in our code base where we hide unsafe
code from valgrind rather than fixing said code. This does not
seem like a place to start such an ugly practice. Performance
does not trump everything else.
I'd be inclined to just remove the pg_rightmost_one_pos64 call
in favor of the other coding you suggest.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2025-01-16 01:44:56 | Re: POC: enable logical decoding when wal_level = 'replica' without a server restart |
| Previous Message | Tom Lane | 2025-01-16 01:27:19 | Re: [PATCH] Hex-coding optimizations using SVE on ARM. |