Re: pgindent (Re: [HACKERS] LONG varsize - how to go on)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Jan Wieck <wieck(at)debis(dot)com>, PostgreSQL HACKERS <pgsql-hackers(at)postgreSQL(dot)org>
Subject: Re: pgindent (Re: [HACKERS] LONG varsize - how to go on)
Date: 1999-12-18 22:14:07
Message-ID: 1520.945555247@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Again, I think everyone liked it at the time, but this may have changed.
>
> Speak up, folks.

I can live with the code layout conventions we have in place; I like K&R
layout better, but not enough to fight about it. It's easy enough to
set up Emacs to handle the style we have.

What I do *not* like is the tab-stops-are-4-spaces convention. As Peter
says, that makes the code look horrible in any tool that can't easily be
adjusted to a nonstandard tab spacing.

My preference would be to use standard 8-space meaning of tabs, but
stick with our current conventions for visible layout of code (4 columns
per logical indent level, etc). That means people contributing code
would need to use editors that understand the difference between a
physical tab character and a logical indent level. I get the impression
that a number of key developers don't use such editors, so maybe
switching over isn't going to be practical.

regards, tom lane

Browse pgsql-hackers by date

  From Date Subject
Next Message Brook Milligan 1999-12-18 23:14:50 Re: [HACKERS] Re: [PATCHES] Lock
Previous Message Tom Lane 1999-12-18 21:57:27 Re: [HACKERS] Anyone for prettyprinted EXPLAIN VERBOSE?