| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Christoph Berg <myon(at)debian(dot)org>, PostgreSQL Bugs <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: Bus error in pg_logical_slot_get_changes (9.4.7, sparc) |
| Date: | 2016-04-14 19:18:36 |
| Message-ID: | 15176.1460661516@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2016-04-14 13:11:43 -0400, Tom Lane wrote:
>> But looking around a bit, I think that ReorderBufferRestoreChange is
>> almost completely broken on alignment-picky machines, if the expectation
>> is that the input data could be aligned arbitrarily.
> 'data' cannot be aligned arbitrarily. It's palloc aligned, and the
> buffer is used separately for everything is loaded from disk. I.e. the
> data pointer passed to ReorderBufferRestoreChange is aligned to a
> MAXALIGN boundary.
Right, I figured that out awhile later; it would have been better if it
was documented. See my second patch attempt.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-04-14 19:24:40 | Re: Bus error in pg_logical_slot_get_changes (9.4.7, sparc) |
| Previous Message | Tom Lane | 2016-04-14 19:14:37 | Re: Bus error in pg_logical_slot_get_changes (9.4.7, sparc) |