BUG #15039: some question about hash index code

From: PG Bug reporting form <noreply(at)postgresql(dot)org>
To: pgsql-bugs(at)lists(dot)postgresql(dot)org
Cc: zoulx1982(at)163(dot)com
Subject: BUG #15039: some question about hash index code
Date: 2018-01-31 11:34:46
Message-ID: 151739848647.1239.12528851873396651946@wrigleys.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

The following bug has been logged on the website:

Bug reference: 15039
Logged by: lixian zou
Email address: zoulx1982(at)163(dot)com
PostgreSQL version: 10.0
Operating system: source code
Description:

hi,
i read hash index code , and found in _hash_addovflpage function, there is
such code :
if (metap->hashm_firstfree == orig_firstfree)
{
metap->hashm_firstfree = bit + 1;
MarkBufferDirty(metabuf);
}

i found no any chang for metap,metap->hashm_firstfree,and initial the two
variable is equal, so maybe the if statement is redundant?

thanks.

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Amit Kapila 2018-01-31 12:06:22 Re: BUG #15039: some question about hash index code
Previous Message Greg Clough 2018-01-31 09:45:19 RE: BUG #15038: Upgrade 8.4 to 9.2 - LC_Collate differs

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Verite 2018-01-31 11:39:53 Re: csv format for psql
Previous Message Dean Rasheed 2018-01-31 10:52:28 Re: WINDOW RANGE patch versus leakproofness