From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, ronan(at)dunklau(dot)fr, Christoph Berg <cb(at)df7cb(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Markus Wanner <markus(at)bluegap(dot)ch> |
Subject: | Re: Hide 'Execution time' in EXPLAIN (COSTS OFF) |
Date: | 2014-10-18 00:39:22 |
Message-ID: | 15161.1413592762@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> On Fri, Oct 17, 2014 at 3:34 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I don't want to go there. It would be a lot better to expend the effort
>> on a better regression testing infrastructure that wouldn't *need*
>> bitwise-identical output across platforms. (mysql is ahead of us in that
>> department: they have some hacks for selective matching of the output.)
> Perhaps we could introduce some sort of wildcard matching in the regression
> tests. So that we could stick something like:
> Execution time: * ms
> Into the expected results, though, probably we'd need to come up with some
> wildcard character which is a bit less common than *
I was imagining that we might as well allow regexp matching, so you could
be as specific as
Execution time: \d+\.\d+ ms
if you had a mind to. But with or without that, it would be difficult to
pick a meta-character that never appears in expected-output files today.
What we'd probably want to do (again, I'm stealing ideas from what I
remember of the mysql regression tests) is add metasyntax to switch
between literal and wildcard/regexp matching. So perhaps an expected
file could contain something like
-- !!match regexp
... expected output including regexps ...
-- !!match literal
... normal expected output here
Not sure how we get there without writing our own diff engine though :-(.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Feng Tian | 2014-10-18 01:25:14 | Re: Optimizer on sort aggregate |
Previous Message | David Rowley | 2014-10-18 00:14:30 | Re: Hide 'Execution time' in EXPLAIN (COSTS OFF) |