From: | Ryan Murphy <ryanfmurphy(at)gmail(dot)com> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org |
Cc: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> |
Subject: | Re: Challenges preventing us moving to 64 bit transaction id (XID)? |
Date: | 2018-01-06 19:10:43 |
Message-ID: | 151526584358.1766.14918985281890942296.pgcf@coridan.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Thanks for this contribution!
I think it's a hard but important problem to upgrade these xids.
Unfortunately, I've confirmed that this patch 0001-64bit-guc-relopt-3.patch doesn't apply correctly on my computer.
Here's what I did:
I did a "git pull" to the current HEAD, which is 6271fceb8a4f07dafe9d67dcf7e849b319bb2647
Then I attempted to apply the patch, here's what I saw:
$ git apply patches/0001-64bit-guc-relopt-3.patch
error: src/backend/access/common/reloptions.c: already exists in working directory
error: src/backend/utils/misc/guc.c: already exists in working directory
error: src/include/access/reloptions.h: already exists in working directory
error: src/include/utils/guc.h: already exists in working directory
error: src/include/utils/guc_tables.h: already exists in working directory
Alexander, what is the process you're using to create the patch? I've heard someone (maybe Tom Lane?) say that he sometimes uses "patch" directly instead of "git" to create the patch, with better results. I forget the exact command.
For now I'm setting this to Waiting on Author, until we have a patch that applies via "git apply".
Thanks!
Ryan
The new status of this patch is: Waiting on Author
From | Date | Subject | |
---|---|---|---|
Next Message | Ryan Murphy | 2018-01-06 20:01:41 | Re: Add default role 'pg_access_server_files' |
Previous Message | Simon Riggs | 2018-01-06 18:38:01 | Re: Rangejoin rebased |