Re: [PATCH] contrib/xml2: xslt_process() should report XSLT-related error details

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Robin Haberkorn" <haberkorn(at)b1-systems(dot)de>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] contrib/xml2: xslt_process() should report XSLT-related error details
Date: 2025-04-23 22:59:10
Message-ID: 1512827.1745449150@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Robin Haberkorn" <haberkorn(at)b1-systems(dot)de> writes:
> btw. you wrote that comment in cacd42d62cb2ddf32135b151f627780a5509780f
> back in 2011.
> The commit message also contains some background information.

Hm. I wonder if we couldn't get rid of the
HAVE_XMLSTRUCTUREDERRORCONTEXT conditionalization. If the
libxml2 versions that lacked that were "old" in 2011, surely
they are extinct in the wild by now. I'm thinking that we
really don't want to be using the generic handler at all, given
the commit log's comment that it can't distinguish between
error, warning, and notice cases.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2025-04-23 23:36:57 Re: Logical Replication of sequences
Previous Message Tom Lane 2025-04-23 22:58:46 Re: Non-reproducible AIO failure