Re: Fwd: pg_trgm word_similarity inconsistencies or bug

From: Jan Przemysław Wójcik <jan(dot)przemyslaw(dot)wojcik(at)gmail(dot)com>
To: pgsql-bugs(at)postgresql(dot)org
Subject: Re: Fwd: pg_trgm word_similarity inconsistencies or bug
Date: 2017-11-07 12:51:35
Message-ID: 1510059095836-0.post@n3.nabble.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Hi,

my statement about the function usefulness was probably too categorical,
though I had in mind the current name of the function.

I'm afraid that creating a function that implements quite different
algorithms depending on a global parameter seems very hacky and would lead
to misunderstandings. I do understand the need of backward compatibility,
but I'd opt for the lesser evil. Perhaps a good idea would be to change the
name to 'substring_similarity()' and introduce the new function
'word_similarity()' later, for example in the next major version release.

------
Jan Przemysław Wójcik

--
Sent from: http://www.postgresql-archive.org/PostgreSQL-bugs-f2117394.html

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message sean.johnston 2017-11-07 13:49:48 BUG #14890: Error grouping by same column twice using FDW
Previous Message Yan Maystrenko 2017-11-07 08:19:08 Returning same row twice in certain conditions

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabrízio de Royes Mello 2017-11-07 12:58:54 Re: [PATCH] A hook for session start
Previous Message Kyotaro HORIGUCHI 2017-11-07 10:54:08 Re: [PATCH] Improve geometric types