Re: Preserve subscription OIDs during pg_upgrade

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Preserve subscription OIDs during pg_upgrade
Date: 2024-02-25 16:34:35
Message-ID: 1502971.1708878875@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

vignesh C <vignesh21(at)gmail(dot)com> writes:
> Recently we have supported upgrade of subscriptions,but currently
> subscription OIDs can be changed when a cluster is upgraded using
> pg_upgrade. It will be better to preserve them as it will be easier to
> compare subscription related objects in pg_subscription and
> pg_subscription_rel in the old and new clusters.

I do not think that's a sufficient argument. For other object types,
we only go through these pushups if we *have to* do so because the
OIDs may appear in user tables or file names. I don't see a reason
that subscriptions deserve special treatment.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2024-02-25 16:46:06 Re: libpq: PQfnumber overload for not null-terminated strings
Previous Message Tom Lane 2024-02-25 16:29:17 Re: Optimize planner memory consumption for huge arrays