Re: patch bug in 9.6 spec

From: Devrim Gündüz <devrim(at)gunduz(dot)org>
To: Martín Marqués <martin(at)2ndquadrant(dot)com>, pgsql-pkg-yum <pgsql-pkg-yum(at)postgresql(dot)org>
Subject: Re: patch bug in 9.6 spec
Date: 2017-07-22 07:59:42
Message-ID: 1500710382.2815.1.camel@gunduz.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-pkg-yum


Hi Martin,

On Thu, 2017-07-06 at 22:16 -0300, Martín Marqués wrote:
> I was making a custom build with a patch for 9.6 and found this which
> seems to be a bug in the spec file of postgresql 9.6.3 src.rpm package:
>
> %patch6 -p1
> %if 0%{?rhel} && 0%{?rhel} <= 5
> %patch7 -p1
> %endif
>
> Compilation passed because I'm using rhel7, but that patch doesn't exist
> in the spec file, so if someone would have tried to compile it on rhel5
> it would have failed.
>
> I didn't do much digging on when it got there, but it seems it would be
> good to remove it.

I think you are using an older version of the spec file -- this is from 9.6.3-2
changelog:

- Remove nonexistent Patch7 reference

I refactored the spec files recently, so please let me know if you see more
issues.

Regards,
--
Devrim Gündüz
EnterpriseDB: https://www.enterprisedb.com
PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR

In response to

Responses

Browse pgsql-pkg-yum by date

  From Date Subject
Next Message Martín Marqués 2017-07-22 10:20:36 Re: patch bug in 9.6 spec
Previous Message Lukas Fittl 2017-07-21 00:15:35 libevent2 requirement in pgbouncer package (1.7.2-7) breaks install on Amazon Linux