Re: Switching timeline over streaming replication

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
Cc: Amit Kapila <amit(dot)kapila(at)huawei(dot)com>, "'PostgreSQL-development'" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Switching timeline over streaming replication
Date: 2012-11-15 14:55:26
Message-ID: 15005.1352991326@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> writes:
> This is a fairly general issue, actually. Looking around, I can see at
> least two similar cases in existing code, with BasicOpenFile, where we
> will leak file descriptors on error:

Um, don't we automatically clean those up during transaction abort?
If we don't, we ought to think about that, not about cluttering calling
code with certain-to-be-inadequate cleanup in error cases.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Shigeru Hanada 2012-11-15 15:09:42 Re: FDW for PostgreSQL
Previous Message Alvaro Herrera 2012-11-15 14:50:37 Re: [PATCH 02/14] Add support for a generic wal reading facility dubbed XLogReader