From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
Cc: | Hongxu Ma <interma(at)outlook(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: PSQL error: total cell count of XXX exceeded |
Date: | 2023-11-21 14:43:16 |
Message-ID: | 1498866.1700577796@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> Right. I made a few more adjustments, including the additional overflow
> check in printTableInit that Tom Lane suggested, and pushed this.
Committed patch LGTM.
> It's a bit annoying that the error recovery decision of this code is to
> exit the process with an error. If somebody were to be interested in a
> fun improvement exercise, it may be worth redoing the print.c API so
> that it returns errors that psql can report and recover from, instead of
> just closing the process.
> TBH though, I've never hit that code in real usage.
Yeah, I think the reason it's stayed like that for 25 years is that
nobody's hit the case in practice. Changing the API would be a bit
troublesome, too, because we don't know if anybody besides psql
uses it.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2023-11-21 14:54:10 | Re: meson documentation build open issues |
Previous Message | Fabrízio de Royes Mello | 2023-11-21 14:34:08 | pg_class.relpages not updated for toast index |