| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Joe Conway <mail(at)joeconway(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: oh dear ... |
| Date: | 2003-11-15 17:30:46 |
| Message-ID: | 14988.1068917446@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Joe Conway <mail(at)joeconway(dot)com> writes:
> Tom Lane wrote:
>> The pgstat patch has already been checked to my satisfaction, but the
>> datetime patch needs more eyeballs on it; anyone out there have time to
>> look at it?
> FWIW, it looks good to me, seems to work as intended, and passes all
> existing regression tests.
I made up a more thorough regression test for date input formats, and
found that there were still some cases that were rejected :-(. Attached
is a more complete patch that handles all month-name cases, and
explicitly can not change the behavior when there's not a textual month
name. Documentation addition and regression test included.
I'd like some further review of this before I risk applying it to 7.4
though ... anyone have time today?
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| unknown_filename | text/plain | 24.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2003-11-15 18:14:34 | Re: [CORE] 7.4RC2 regression failur and not running stats |
| Previous Message | Bruce Momjian | 2003-11-15 15:54:46 | Re: cvs head? initdb? |