Re: Replacing TAP test planning with done_testing()

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Replacing TAP test planning with done_testing()
Date: 2022-02-09 19:49:47
Message-ID: 1497212.1644436187@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

=?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari(at)ilmari(dot)org> writes:
> Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>> The attached patch removes all Test::More planning and instead ensures that all
>> tests conclude with a done_testing() call. While there, I also removed a few
>> exit(0) calls from individual tests making them more consistent.

> LGTM, +1.

LGTM too.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2022-02-09 20:05:02 Re: is the base backup protocol used by out-of-core tools?
Previous Message Robert Haas 2022-02-09 19:30:08 Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints