Re: pg_upgrade libraries check

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> I assumed I could just have pg_upgrade create and drop the extension in
> the new database to make sure it works. In the JSON backpatch case, the
> extension file would just do nothing, as has already been suggested.

It seems like checking for the control file being present should be
sufficient. I don't think it's part of pg_upgrade's job description to
test whether the new installation is broken. And we don't really want
it cluttering the new installation with dead objects right off the bat
(could cause OID issues or LSN issues, for instance).

> In fact, can we identify right now if a function is used only by an
> extension?

ITYM is the function defined by an extension, and the answer to that is
"look in pg_depend".

regards, tom lane