| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-hackers(at)postgreSQL(dot)org |
| Subject: | Another hole detected in pg_upgrade |
| Date: | 2000-09-19 21:13:16 |
| Message-ID: | 14951.969397996@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I have just noticed that VACUUM doesn't always call
FlushRelationBuffers(); it does so only if it wants to truncate
the relation (ie, shrink the physical file).
This is OK for normal purposes but it's bad for pg_upgrade, which
is invoking VACUUM just to ensure that on-row transaction status bits
are set correctly. Without FlushRelationBuffers(), pages that only
had status bit updates may never get written back to disk...
I have fixed VACUUM so that FlushRelationBuffers() will be called in
all execution paths, and back-patched the fix into REL7_0 branch.
This looks like another good reason for a 7.0.3 release :-(
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tatsuo Ishii | 2000-09-20 00:21:02 | -S is missing in postgresql.conf? |
| Previous Message | Michael Meskes | 2000-09-19 21:04:53 | Re: Library versioning |