| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Jeremy Drake <pgsql(at)jdrake(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge |
| Date: | 2011-09-04 01:08:41 |
| Message-ID: | 14938.1315098521@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Alvaro Herrera wrote:
>> Hmm, so you included walsender.h into xlog.h? That seems a bit funny
>> considering that walsender.h already includes xlog.h. It seems the
>> reason for this is only the AllowCascadeReplication() definition. Maybe
>> that should go elsewhere instead, for example walsender.h?
> Moved to walsender.h. Thanks.
You seem to have entirely missed the point of Alvaro's remark, which is
that you've got xlog.h including walsender.h (still) as well as
walsender.h including xlog.h. That's broken.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2011-09-04 01:25:17 | Re: Re: [COMMITTERS] pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge |
| Previous Message | Bruce Momjian | 2011-09-04 00:51:13 | Re: [COMMITTERS] pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2011-09-04 01:25:17 | Re: Re: [COMMITTERS] pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge |
| Previous Message | Bruce Momjian | 2011-09-04 00:51:13 | Re: [COMMITTERS] pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge |