Re: "debug_invalidate_system_caches_always" is too long

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: "debug_invalidate_system_caches_always" is too long
Date: 2021-07-05 19:13:41
Message-ID: 1492832.1625512421@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Noah Misch <noah(at)leadboat(dot)com> writes:
> On Sun, Jul 04, 2021 at 04:27:13PM -0400, Tom Lane wrote:
>> However, I think we should also give serious consideration to
>> "debug_clobber_cache" or "debug_clobber_cache_always" for continuity
>> with past practice (though it still feels like "always" is a good
>> word to lose now). "debug_clobber_caches" is another reasonable
>> variant.

> https://en.wikipedia.org/wiki/Clobbering refers to cases where storage had no
> changes to its accessibility but now contains different data. That doesn't
> match InvalidateSystemCaches() especially well, so I think dropping that word
> has been a good step. Some other shorter terms could be debug_flush_caches,
> debug_rebuild_caches, or debug_expire_caches. (debug_caches is tempting, but
> that may ensnare folks looking for extra logging rather than a big slowdown.)

I like "debug_flush_caches" --- it's short and accurate.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message James Coleman 2021-07-05 19:33:59 Re: Add proper planner support for ORDER BY / DISTINCT aggregates
Previous Message James Coleman 2021-07-05 19:12:51 Re: Add proper planner support for ORDER BY / DISTINCT aggregates