Re: [HACKERS] Two phase commit in ECPG

From: Michael Meskes <meskes(at)postgresql(dot)org>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, pgsql-bugs <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: [HACKERS] Two phase commit in ECPG
Date: 2017-03-03 19:11:32
Message-ID: 1488568292.2280.2.camel@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Dear Sawada-san,

> This cause is that the "begin transaction" is issued automatically
> before executing COMMIT PREPARED if we're not in auto commit. The
> Commit 816b008eaf1a1ff1069f3bafff363a9a8bf04a21 fixed bug of
> incorrect
> status calculation but at the same time it became the cause of this
> behavior.
> Is this a bug?

I'd say so, yes.

As soon as I find time I'll get to it including back porting your
patch.

Thank you very much for spotting and fixing.

Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael at xmpp dot meskes dot org
VfL Borussia! Força Barça! SF 49ers! Use Debian GNU/Linux, PostgreSQL

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Robert Haas 2017-03-04 05:52:09 Re: [BUGS] Seems bug in postgres_fdw?
Previous Message from-postgresql 2017-03-03 17:56:26 BUG #14576: JDBC's PreparedStatement.getParameterMetaData fails with 'could not determine polymorphic type'

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Verite 2017-03-03 19:11:49 Re: One-shot expanded output in psql using \gx
Previous Message Petr Jelinek 2017-03-03 18:58:12 Re: DROP SUBSCRIPTION and ROLLBACK