From: | Bernd Helmle <mailings(at)oopsware(dot)de> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | Michael Banck <michael(dot)banck(at)credativ(dot)de>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [patch] reorder tablespaces in basebackup tar stream for backup_label |
Date: | 2017-03-03 16:13:06 |
Message-ID: | 1488557586.24682.17.camel@oopsware.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Am Freitag, den 03.03.2017, 15:44 +0900 schrieb Michael Paquier:
> So, the main directory is located at the end on purpose. When using
> --wal-method=fetch the WAL segments are part of the main tarball, so
> if you send the main tarball first you would need to generate a
> second
> tarball with the WAL segments that have been generated between the
> moment the main tarball has finished until the end of the last
> tablespace taken if you want to have a consistent backup. Your patch
> would work with the stream mode though.
Ah right, i assumed there must be something, otherwise the comment
won't be there ;)
We could special case that part to distinguish fetch/stream mode, but i
fear that leads to more confusion than it wants to fix. The other
option of a separate tar file looks awkward from a usability point of
view.
From | Date | Subject | |
---|---|---|---|
Next Message | Masahiko Sawada | 2017-03-03 16:13:17 | Re: GUC for cleanup indexes threshold. |
Previous Message | Stephen Frost | 2017-03-03 15:08:18 | Re: pg_upgrade loses security lables and COMMENTs on blobs |