Re: Keep ECPG comment for log_min_duration_statement

From: "Dr(dot) Michael Meskes" <michael(dot)meskes(at)credativ(dot)com>
To: "Okano, Naoki" <okano(dot)naoki(at)jp(dot)fujitsu(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Keep ECPG comment for log_min_duration_statement
Date: 2017-02-23 14:46:02
Message-ID: 1487861162.2458.124.camel@credativ.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,
   
> So, I'd like to modify ecpg command not to remove some specific
> comments.
> ...
> [Interface]
> add a new option "--enable-parse-comment" to ecpg command.
>  
>  <usage> ecpg --enable-parse-comment ,..., prog.pgc
>  
> This option enables ecpg command to pass on block comments (/* 〜 */)
> to converted C file.

The reason for not keeping the comments in the statement was simply to
make the parser simpler. If you added this feature, do we still see a
reason for keeping the old version? Or in other words, shouldn't we
make the "enable-parse-comment" version the default without a new
option?

Michael
--
Dr. Michael Meskes, Geschaeftsfuehrer/CEO
Tel.: +49 (0)2166 / 99 01 0
E-Mail: michael(dot)meskes(at)credativ(dot)com
IM: mme(at)jabber(dot)credativ(dot)com
PGP: BBBC 58B4 5994 CF9C CC56  BCDA DF23 DA33 9697 8EB3

credativ international GmbH, HRB Moenchengladbach 15543, 
Trompeterallee 108, 41189 Moenchengladbach, Germany
Geschaeftsfuehrung: Dr. Michael Meskes, Joerg Folz

======================================
Global:         http://credativ.com
Germany:        http://credativ.de
Netherlands:    http://credativ.nl
India:          http://credativ.in
UK:             http://credativ.co.uk
USA:            http://credativ.us
======================================

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2017-02-23 14:52:44 Re: user mapping messages
Previous Message Tom Lane 2017-02-23 14:20:58 Re: Make subquery alias optional in FROM clause