| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Jan Otto <asche(at)me(dot)com> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgreSQL(dot)org |
| Subject: | Re: More Snow Leopard fun: multiarch problems while building plperl |
| Date: | 2009-09-08 18:46:43 |
| Message-ID: | 14878.1252435603@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Jan Otto <asche(at)me(dot)com> writes:
> Ups, my previous patch was already applied in HEAD. This patch removes
> the sed-patch and added the check and set of ARCHFLAGS.
This seems to be assuming a lot more about the behavior of Apple's Perl
hacks than I think we should. The patch as committed is good, because
having any -arch flags in $perl_embed_ldflags is flat out wrong no
matter what. They need to be in some other variable such as CFLAGS
in order to have the desired effect.
If you're proposing that the whole Postgres build system start paying
attention to ARCHFLAGS instead of/in addition to CFLAGS, we could talk
about that, but it'll be a much larger patch. See also the thread here
http://archives.postgresql.org/pgsql-hackers/2008-07/msg00884.php
which points out that propagating -arch is the least of our worries.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jan Otto | 2009-09-08 19:19:31 | Re: More Snow Leopard fun: multiarch problems while building plperl |
| Previous Message | Ron Mayer | 2009-09-08 18:45:01 | Re: Time-based Releases WAS: 8.5 release timetable, again |