Re: pg_regress breaks on msys

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_regress breaks on msys
Date: 2006-07-19 18:40:17
Message-ID: 14863.1153334417@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

After looking at the presumably-working uses of system() in initdb and
pg_ctl, I have a theory about the pg_regress problem --- could it be
that Windows system() requires a space between I/O redirection symbols
and pathnames? I see that the pre-existing code consistently puts one,
except in cases like "2>&1":

snprintf(cmd, MAXPGPATH, "%s\"%s\" %s%s < \"%s\" >> \"%s\" 2>&1 &%s",
SYSTEMQUOTE, postgres_path, pgdata_opt, post_opts,
DEVNULL, log_file, SYSTEMQUOTE);

but there's nothing in our docs saying this is necessary ...

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2006-07-19 18:42:49 Re: lastval exposes information that currval does not
Previous Message Andrew Dunstan 2006-07-19 18:39:42 Re: pg_regress breaks on msys

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2006-07-19 18:45:58 Re: pg_regress breaks on msys
Previous Message Andrew Dunstan 2006-07-19 18:39:42 Re: pg_regress breaks on msys