Re: pgsql: Improve error reporting when location specified by postgres -D d

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Improve error reporting when location specified by postgres -D d
Date: 2016-02-03 04:26:09
Message-ID: 1486.1454473569@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> + if (configdir && stat(configdir, &stat_buf) != 0)
> + {
> + write_stderr("%s: could not access \"%s\": %s\n",
> + progname,
> + configdir,
> + strerror(errno));

Perhaps "could not access directory ..."? This doesn't seem to follow the
message style guideline about specifying what sort of object you're
complaining about.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-02-03 05:41:46 Re: pgsql: Add support for systemd service notifications
Previous Message Peter Eisentraut 2016-02-03 02:31:25 pgsql: Add support for systemd service notifications