Re: Adding commit details to SGML release notes

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Adding commit details to SGML release notes
Date: 2015-08-28 21:32:38
Message-ID: 1486.1440797558@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Bruce Momjian wrote:
>> To simplify the creation of the release note with the commit tag as an
>> SGML comment, I think src/tools/git_changelog should be modified to
>> output this string. The format "trunc" feature was added in git 1.8.3.
>> Is that old enough for everyone?

> Since it's only needed by people preparing the release notes, I would
> guess it's okay --- evidently Tom was able to use it.

Well, that's only because I'm running a hand-installed git rather than
what RHEL6 comes with.

> Maybe an option is to use trunc when git 1.8.3 or newer is detected, and
> plain (no trunc) otherwise?

Personally I find that truncated output to be pretty unreadable, and
would strongly object to changing git_changelog so that that was the only
possible format. However, I have no objection to making it an option
("git_changelog --short", or so), and that would dodge any concerns about
failing on git versions without the feature.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2015-08-28 21:49:35 Re: Adding commit details to SGML release notes
Previous Message Alvaro Herrera 2015-08-28 21:27:06 Re: Adding commit details to SGML release notes

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2015-08-28 21:49:35 Re: Adding commit details to SGML release notes
Previous Message Alvaro Herrera 2015-08-28 21:27:06 Re: Adding commit details to SGML release notes