Re: message string fixes

Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Teodor Sigaev wrote:
>> Hmm. If regis detects an error in expression then it will be an error for
>> regex library too. At least, it was supposed to be.

> And those that are not, probably are not what the user intends anyway,
> with the pattern language being so narrow.

It looks to me like RS_isRegis() needs to be tightened up a bit anyway:
it will accept "^foo" which is valid regex but not valid regis, leading
to an error being thrown which is not what we want.

If we tighten it to exactly match what RS_compile() will take ... say
by using the same state-machine logic ... then indeed the ereports
are internal and can be demoted to elog's. If we make them elogs then
ISTM they ought to keep saying regis, just so we know where to look
if they ever do fail ;-)

regards, tom lane