Re: Regex with > 32k different chars causes a backend crash

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Regex with > 32k different chars causes a backend crash
Date: 2013-04-03 15:21:27
Message-ID: 14833.1365002487@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> writes:
> A regex with that many different colors is an extreme case, so I think
> it's enough to turn the assertion in newcolor() into a run-time check,
> and throw a "too many colors in regexp" error. Alternatively, we could
> expand 'color' from short to int, but that would double the memory usage
> of sane regexps with less different characters.

Obviously Henry didn't think that far ahead. I agree that throwing
an error is the best solution, and that widening "color" is probably
not what we want to do. You want to fix that, or shall I?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2013-04-03 15:24:26 Re: Regex with > 32k different chars causes a backend crash
Previous Message Heikki Linnakangas 2013-04-03 15:11:28 Regex with > 32k different chars causes a backend crash