| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Neil Conway <neilc(at)samurai(dot)com> |
| Cc: | Pavel Stehule <stehule(at)kix(dot)fsv(dot)cvut(dot)cz>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: [HACKERS] Implementation of SQLCODE and SQLERRM variables for |
| Date: | 2005-03-07 22:31:16 |
| Message-ID: | 14780.1110234676@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Neil Conway <neilc(at)samurai(dot)com> writes:
> - Is there a reason why you've made the type of SQLCODE `text', rather
> than integer?
The value isn't an integer ... which gets back to my point that this is
not compatible with Oracle's idea of SQLCODE and therefore we should *not*
use that name for it.
BTW: the patch has some memory-leak problems, I believe, because it is
studiously not following the var->freeval protocol. Now that I look,
it appears to be copied-and-pasted from some existing code that also
gets this wrong :-(
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Gaetano Mendola | 2005-03-07 23:52:28 | One vacuum full is not enough. |
| Previous Message | Neil Conway | 2005-03-07 22:21:34 | Re: [HACKERS] Implementation of SQLCODE and SQLERRM variables |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Sabino Mullane | 2005-03-07 23:56:00 | Re: Continue transactions after errors in psql |
| Previous Message | Neil Conway | 2005-03-07 22:21:34 | Re: [HACKERS] Implementation of SQLCODE and SQLERRM variables |