Re: "insert [...] on conflict" hangs on conflict on an unmentioned gist index

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Geoghegan <pg(at)heroku(dot)com>
Cc: pgsql-bugs(at)postgresql(dot)org, Miko Kiiski <miko(dot)kiiski(at)reaktor(dot)com>, Heikki Rauhala <heikki(dot)rauhala(at)reaktor(dot)fi>
Subject: Re: "insert [...] on conflict" hangs on conflict on an unmentioned gist index
Date: 2016-07-04 16:38:01
Message-ID: 1474.1467650281@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

I wrote:
> It looks to me like the ON CONFLICT code has exactly zero chance of
> working with non-btree (or more generally, non-amcanunique) indexes.

Nah, I take that back --- I was expecting this to be handled somewhere
else than it is. It looks like the actual cause is just sloppy
handling of noDupErr in ExecInsertIndexTuples; the attached fixes it
for me.

regards, tom lane

Attachment Content-Type Size
fix-non-arbiter-exclusion-index.patch text/x-diff 648 bytes

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Peter Geoghegan 2016-07-04 17:35:46 Re: "insert [...] on conflict" hangs on conflict on an unmentioned gist index
Previous Message Tom Lane 2016-07-04 16:09:32 Re: BUG #14226: pg_upgrade for 8.4 to 9.4 failed