Re: BUG #16703: pg-dump fails to process recursive view definition

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: exclusion(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #16703: pg-dump fails to process recursive view definition
Date: 2020-11-05 15:41:48
Message-ID: 1473888.1604590908@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

I wrote:
> It seems like the least painful solution might be to teach
> LockTableRecurse to detect recursion and just not recurse into
> a view it's already locked. (BTW, I wonder if we shouldn't
> have a stack depth check there, too.)

Oh, I see it already has a recursion test ... it's just that throwing
an error is an unnecessarily harsh reaction. We can just stop
recursing. Will push a fix shortly.

(Also, we need no check_stack_depth call here, because
expression_tree_walker has one.)

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2020-11-05 16:20:29 Re: BUG #16703: pg-dump fails to process recursive view definition
Previous Message Wolfgang Walther 2020-11-05 15:06:01 Re: Wrong result for comparing ROW(...) with IS NOT NULL