| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Aidan Van Dyk <aidan(at)highrise(dot)ca> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, "David E(dot) Wheeler" <david(at)kineticode(dot)com>, Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, Marti Raudsepp <marti(at)juffo(dot)org>, peter_e(at)gmx(dot)net, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: renaming contrib. (was multi-platform, multi-locale regression tests) |
| Date: | 2010-11-11 15:24:15 |
| Message-ID: | 14723.1289489055@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Aidan Van Dyk <aidan(at)highrise(dot)ca> writes:
>>> It's intentional behavior. It gives up when there are too many
>>> differences to avoid being slow.
> And, it's configurable, at least to diff and merge. If it's not
> available in all the other porcelains, yes, that would be bugs that
> should be fixed:
FWIW, I was seeing this with git cherry-pick, whose man page gives no
hint of supporting any such option.
> -l<num>
> The -M and -C options require O(n^2) processing time where
> n is the number of potential
> rename/copy targets. This option prevents rename/copy
> detection from running if the number
> of rename/copy targets exceeds the specified number.
Given that we have, in fact, never renamed any files in the history of
the project, I'm wondering exactly why it thinks that the number of
potential rename/copy targets isn't zero. The whole thing smells
broken to me, which is why I am unhappy about the idea of suddenly
starting to depend on it in a big way.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Marti Raudsepp | 2010-11-11 15:28:11 | Re: renaming contrib. (was multi-platform, multi-locale regression tests) |
| Previous Message | Aidan Van Dyk | 2010-11-11 15:17:15 | Re: renaming contrib. (was multi-platform, multi-locale regression tests) |