| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "Karl O(dot) Pinc" <kop(at)meme(dot)com> |
| Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Marko Tiikkaja <marko(at)joh(dot)to>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: proposal: minscale, rtrim, btrim functions for numeric |
| Date: | 2019-12-08 18:57:00 |
| Message-ID: | 14700.1575831420@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
"Karl O. Pinc" <kop(at)meme(dot)com> writes:
> FWIW, I bumped around the Internet and looked at Oracle docs to see if
> there's any reason why minscale() might not be a good function name.
> I couldn't find any problems.
> I also couldn't think of a better name than trim_scale() and don't
> have any problems with the name.
I'd just comment that it seems weird that the same patch is introducing
two functions with inconsistently chosen names. Why does one have
an underscore separating the words and the other not? I haven't got
a large investment in either naming convention specifically, but it'd
be nice if we could at least pretend to be considering consistency.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-12-08 19:14:03 | Re: [Proposal] Level4 Warnings show many shadow vars |
| Previous Message | Tom Lane | 2019-12-08 18:51:57 | Re: [Proposal] Level4 Warnings show many shadow vars |