Re: Patch for Improved Syntax Error Reporting

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Neil Padgett <npadgett(at)redhat(dot)com>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Dave Page <dpage(at)vale-housing(dot)co(dot)uk>, "'Fernando Nasser'" <fnasser(at)cygnus(dot)com>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Patch for Improved Syntax Error Reporting
Date: 2001-08-02 23:30:02
Message-ID: 14696.996795002@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Neil Padgett <npadgett(at)redhat(dot)com> writes:
>> I like the idea of putting the formatting stuff in libpq. It
>> centralizes it, and allows the client to control the formatting too.

> What exactly would you put in libpq?

I think we could put in code that parses the multi-line error message
format, and returns preparsed data in the form of a list of field names
and field values. I don't see that libpq can do anything useful with
producing a syntax-error pointer, since it doesn't have access to the
original user query string, only to the same string that's sent to the
backend; so as far as it can know, the error index that the backend
returns is gospel. Any reverse-mapping from that to a user-query index
has got to be in the client app, AFAICS.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Hiroshi Inoue 2001-08-02 23:37:19 Re: ODBC Boolean handling
Previous Message Tom Lane 2001-08-02 23:26:19 Re: Revised Patch to allow multiple table locks in "Unison"