From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, pgsql-patches(at)postgresql(dot)org |
Subject: | Re: Fix for erroneous warning on Shutdown |
Date: | 2004-06-16 01:01:57 |
Message-ID: | 14610.1087347717@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers-win32 pgsql-patches |
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> I just did CHECKPOINT;CHECKPOINT and got the warning in the logs. This
> needs to be fixed.
See code:
/*
* Ideally we should only warn if this checkpoint was
* requested due to running out of segment files, and not
* if it was manually requested. However we can't tell the
* difference with the current signalling mechanism.
*/
I could argue that a client-driven process that issues CHECKPOINT every
few seconds is equally deserving of a warning. The only thing wrong is
that the HINT is inapplicable ... but that's why it's a HINT and not
part of the main message.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2004-06-16 01:47:45 | Re: Fix for erroneous warning on Shutdown |
Previous Message | Bruce Momjian | 2004-06-16 00:58:43 | Re: Fix for erroneous warning on Shutdown |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2004-06-16 01:47:45 | Re: Fix for erroneous warning on Shutdown |
Previous Message | Bruce Momjian | 2004-06-16 00:58:43 | Re: Fix for erroneous warning on Shutdown |