Re: pg_upgrade check for invalid databases

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Thomas Krennwallner <tk(at)postsubmeta(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_upgrade check for invalid databases
Date: 2024-09-30 14:55:39
Message-ID: 1455756.1727708139@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:
> Should we have pg_upgrade skip invalid databases? If the only valid action
> is to drop them, IMHO it seems unnecessary to require users to manually
> drop them before retrying pg_upgrade.

I was thinking the same. But I wonder if there is any chance of
losing data that could be recoverable. It feels like this should
not be a default behavior.

TBH I'm not finding anything very much wrong with the current
behavior... this has to be a rare situation, do we need to add
debatable behavior to make it easier?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2024-09-30 15:05:34 Re: msys inet_pton strangeness
Previous Message Maxim Orlov 2024-09-30 14:49:36 Do not lock temp relations