| From: | Sergei Kornilov <sk(at)zsrv(dot)org> |
|---|---|
| To: | Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Integrate recovery.conf into postgresql.conf |
| Date: | 2018-11-26 18:34:38 |
| Message-ID: | 145311543257278@sas1-0a6c2e2b59d7.qloud-c.yandex.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Hello
> I think I would have done 'if (targetSettingsCount != 1)' here.
Streaming replication does not have any recovery_target.
Well, i can check StandbyModeRequested too and allow 0 recovery_target only for standby mode.
>> -# Multiple targets
>> -# Last entry has priority (note that an array respects the order of items
>> -# not hashes).
>
> You could (and imv should) include a test that throws an expected error
> if multiple targets are specified.
We have some example for checking unable-to-start DB? Did not find yet
> Let’s at least fix the currently committed patch before adding new features or changing how things in recovery work.
+1
regards, Sergei
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2018-11-26 19:12:53 | Re: pgsql: Integrate recovery.conf into postgresql.conf |
| Previous Message | Andres Freund | 2018-11-26 18:32:18 | Re: pgsql: Integrate recovery.conf into postgresql.conf |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2018-11-26 18:45:09 | Re: dsa_allocate() faliure |
| Previous Message | Andres Freund | 2018-11-26 18:32:18 | Re: pgsql: Integrate recovery.conf into postgresql.conf |