| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers(at)postgreSQL(dot)org |
| Subject: | Re: atexit_callback can be a net negative |
| Date: | 2014-03-07 14:49:05 |
| Message-ID: | 14497.1394203745@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> On 2014-03-07 00:03:48 -0500, Tom Lane wrote:
>> In the bug thread I proposed making atexit_callback check whether getpid()
>> still matches MyProcPid.
> What are you proposing to do in that case? This is only one of the
> failure cases of forking carelessly, right?
No, I think it should do nothing. The coding pattern shown in bug #9464
seems perfectly reasonable and I think we should allow it. No doubt it's
safer if the child process does an on_exit_reset; but right now, if the
child fails to do so, atexit_callback is actively breaking things. And
I don't think we can rely on third-party libraries to call on_exit_reset
after forking.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2014-03-07 14:57:14 | Re: atexit_callback can be a net negative |
| Previous Message | Craig Ringer | 2014-03-07 14:41:27 | Re: Row-security on updatable s.b. views |