| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: GCC 7 warnings |
| Date: | 2017-04-10 16:25:59 |
| Message-ID: | 14447.1491841559@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> Possible fixes:
> a) Ignore, hoping GCC will change before final release. (unlikely at
> this point)
> b) Add compiler option to disable this particular warning, worry about
> it later. (Might be an option for backpatching.)
> c) Expand the target buffer sizes until the warning goes away. (Sample
> patch attached.)
> d) Replace most of the problematic code with psprintf() and dynamically
> sized buffers.
+1 for (c) as you have it. Later we might think about selectively
doing (d), but it seems like more work for probably not much benefit.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2017-04-10 16:39:06 | Re: max_sync_workers_per_subscription is missing in postgresql.conf |
| Previous Message | Andres Freund | 2017-04-10 16:23:38 | Re: Adding lfirst_node (was Re: [sqlsmith] Planner crash on foreign table join) |