From: | zhangjinyu <beijing_pg(at)163(dot)com> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Patch: Optimize memory allocation in function 'bringetbitmap' |
Date: | 2015-09-28 14:40:54 |
Message-ID: | 1443451254826-5867647.post@n5.nabble.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Yes, I forgot disable-c-assert last test.
The following show the test result when disable-c-assert.
I think it's still worthwhile.
*After optimize code (warm run)*
postgres=# select count(*) from lineitem where l_orderkey=1;
count
-------
6
(1 row)
Time: 327.143 ms
*Before optimizing code (warm run)*
postgres=# select count(*) from lineitem where l_orderkey=1;
count
-------
6
(1 row)
Time: 404.323 ms
>>>>However I wonder if it would be simpler to have the dtup structure have
>>>>the pointers, so that you can pass it as NULL in the first call and then
>>>>followup calls reuse the one allocated in the first call.
Jinyu: the memory is allocated from perRangeCxt and perRangeCxt will be
reset in loop,
so this way don't work.
Jinyu Zhang
--
View this message in context: http://postgresql.nabble.com/Patch-Optimize-memory-allocation-in-function-bringetbitmap-tp5867537p5867647.html
Sent from the PostgreSQL - hackers mailing list archive at Nabble.com.
From | Date | Subject | |
---|---|---|---|
Next Message | zhangjinyu | 2015-09-28 14:47:21 | Re: BRIN Scan: Optimize memory allocation in function 'bringetbitmap' |
Previous Message | Marti Raudsepp | 2015-09-28 14:28:19 | Re: BRIN indexes for MAX, MIN, ORDER BY? |