| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Euler Taveira de Oliveira <euler(at)timbira(dot)com>, Emanuel <postgres(dot)arg(at)gmail(dot)com>, pgsql-bugs <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: BUG #6041: Unlogged table was created bad in slave node |
| Date: | 2011-06-07 15:50:23 |
| Message-ID: | 14416.1307461823@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> Patch along these lines attached.
Frankly, I find this quite ugly, and much prefer the general approach of
your previous patch in <BANLkTim433vF5HWjbJ0FSWm_-xA8DDaGNg(at)mail(dot)gmail(dot)com>.
However, I don't like where you put the execution-time test there. I'd
put it in ExecOpenScanRelation instead, so that it covers both seqscan
and indexscan accesses.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2011-06-07 17:42:46 | Re: BUG #6041: Unlogged table was created bad in slave node |
| Previous Message | Daniel Cristian Cruz | 2011-06-07 15:43:37 | Re: BUG #6050: Dump and restore of view after a schema change: can't restore the view |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joshua D. Drake | 2011-06-07 15:56:45 | Re: reducing the overhead of frequent table locks - now, with WIP patch |
| Previous Message | Heikki Linnakangas | 2011-06-07 15:36:29 | Re: WALInsertLock tuning |