Re: Parsing errors in pg_hba.conf

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Parsing errors in pg_hba.conf
Date: 2008-10-27 12:27:13
Message-ID: 14373.1225110433@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Magnus Hagander <magnus(at)hagander(dot)net> writes:
> In a number of places in pg_hba.conf, we don't actually log what goes
> wrong - instead we just goto a label that will log "invalid token \"%s\"".

> Is there any special reason for this, other than the fact that it was
> the easy way out? I think it would be reasonable to for example log
> "hostssl not supported on this platform" instead of that, when USE_SSL
> is not defined, etc.

It would be seriously messy to try to make the parse-error code know
about things like that. Better would be to keep the GUC variable in
existence always and have an assign hook to throw the error.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-10-27 12:28:47 Re: Full socket send buffer prevents cancel, timeout
Previous Message Alvaro Herrera 2008-10-27 12:19:33 Re: Parsing errors in pg_hba.conf