From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Teodor Sigaev <teodor(at)sigaev(dot)ru> |
Cc: | Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: vacuum and row type |
Date: | 2011-06-03 02:21:13 |
Message-ID: | 14357.1307067673@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
I wrote:
> What I was thinking last night is that it'd be smart to move all this
> logic into the typcache, instead of repeating all the work each time we
> make the check.
Attached is a proposed patch that does it that way. I haven't finished
poking around to see if there are any other places besides
get_sort_group_operators where there is now-redundant code, but this
does pass regression tests.
Although this is arguably a bug fix, I'm not sure whether to back-patch
it. Given the lack of field complaints, it may not be worth taking any
risk for. Thoughts?
regards, tom lane
Attachment | Content-Type | Size |
---|---|---|
typcache-rowtype-checking.patch | text/x-patch | 24.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | fanngyuan | 2011-06-03 02:52:47 | how to get the max value in an array |
Previous Message | Jun Ishiduka | 2011-06-03 01:58:21 | Re: Online base backup from the hot-standby |