Re: pgbouncer logrotate configuration

Hi,

On Tue, 2015-05-12 at 10:44 -0400, Peter Eisentraut wrote:
> The pgbouncer logrotate configuration seems a bit contradictory:
>
> /var/log/pgbouncer.log {
> missingok
> notifempty
> sharedscripts
> copytruncate
> create 0640 pgbouncer pgbouncer
> nodateext
> postrotate
> /bin/kill -HUP `cat /var/run/pgbouncer/pgbouncer.pid
> 2>/dev/null` 2> /dev/null || true
> endscript
> }
>
> "create" is ignored if "copytruncate" is used. And having a postrotate
> script to send a HUP signal is also pointless if copytruncate is used.
> We need to decide on one way to do it: either copytruncate, or rename
> and SIGHUP.
>
> It also seems to me that this might be a bit simpler if we created a
> subdirectory /var/log/pgbouncer/ for all the log files. Then we
> wouldn't have the permissions issues that the "create" directory is
> attempting to solve.

Just committed a fix for this. Can you please pull 9.4 tree and see
whether all problems you reported have been fixed or not? I can push the
packages tomorrow or so.

Regards,

--
Devrim GÜNDÜZ
Principal Systems Engineer @ EnterpriseDB: http://www.enterprisedb.com
PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR