From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Oliver Elphick <olly(at)lfix(dot)co(dot)uk> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Some architectures need "signed char" declarations |
Date: | 2002-01-09 19:15:56 |
Message-ID: | 14306.1010603756@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Oliver Elphick <olly(at)lfix(dot)co(dot)uk> writes:
> I recently got a Debian bug report about 3 architectures where char is
> unsigned by default. There were 2 locations identified in the code
> where a char is compared with a negative value, and should therefore be
> declared as a "signed char". There may be others in 7.2, but I don't
> myself have access to a suitable machine for testing.
> The locations I am aware of are:
> src/backend/libpq/hba.c GetCharSetByHost(): if (c =3D=3D EOF)
> src/backend/utils/init/miscinit.c SetCharSet(): if (c =3D=3D EOF)
Fix committed. I looked at every use of "EOF" in the distribution, and
those two are the only ones I could find that were wrong. I did also
find a place where the result of "getopt" was incorrectly stored in a
"char".
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2002-01-09 19:48:28 | Re: again on index usage |
Previous Message | Marc G. Fournier | 2002-01-09 18:02:19 | Re: RC1 time? |