Re: Improve Assert output

Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> This kind of output is usually not helpful:
> TRAP: BadArgument("((context) != ((void *)0) && (((((const
> Node*)((context)))->type) == T_AllocSetContext) || ((((const
> Node*)((context)))->type) == T_SlabContext) || ((((const
> Node*)((context)))->type) == T_GenerationContext)))", File:
> "../../../../src/include/utils/memutils.h", Line: 129)

> What we probably want is something like:

> TRAP: BadArgument("MemoryContextIsValid(context)", File:
> "../../../../src/include/utils/memutils.h", Line: 129)

+1, that would be a big improvement. The other thing that this
is fixing is that the existing output for Assert et al shows
the *inverted* condition, which I for one always found confusing.

I didn't try to test the patch, but it passes eyeball examination.

regards, tom lane